Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-66480] Add fallback reference build for multibranch projects. #368

Merged
merged 8 commits into from
Nov 7, 2021

Conversation

uhafner
Copy link
Member

@uhafner uhafner commented Nov 3, 2021

If the reference build detection does not work because the number of recorded commits is not large enough, then as a
fallback for pull requests the last build of the target branch will be returned as reference build.

If the reference build detection does not work because the
number of recorded commits is not large enough, then as a
fallback for pull requests the last build of the target
branch will be returned as reference build.
@uhafner uhafner added the enhancement Enhancement of existing functionality label Nov 3, 2021
@uhafner uhafner changed the title Add fallback reference build for multibranch projects. [JENKINS-66480] Add fallback reference build for multibranch projects. Nov 3, 2021
@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #368 (6b54f54) into master (36f41ba) will increase coverage by 0.63%.
The diff coverage is 89.09%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #368      +/-   ##
============================================
+ Coverage     80.12%   80.76%   +0.63%     
- Complexity      157      162       +5     
============================================
  Files            22       22              
  Lines           644      681      +37     
  Branches         69       73       +4     
============================================
+ Hits            516      550      +34     
- Misses          100      104       +4     
+ Partials         28       27       -1     
Impacted Files Coverage Δ
.../forensics/git/reference/GitReferenceRecorder.java 89.58% <82.75%> (+16.25%) ⬆️
...gins/forensics/git/reference/GitCommitsRecord.java 83.54% <96.15%> (+5.21%) ⬆️
...gins/forensics/git/miner/CommitStatisticsStep.java 67.10% <0.00%> (-10.53%) ⬇️
...plugins/forensics/git/miner/MergeBaseSelector.java 86.66% <0.00%> (+13.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36f41ba...6b54f54. Read the comment docs.

@uhafner uhafner marked this pull request as ready for review November 6, 2021 20:51
Add a new test for the descriptor UI methods.
Add a test with a job that has not yet a `GitCommitsRecord`.
@uhafner uhafner merged commit 59e1897 into master Nov 7, 2021
@uhafner uhafner deleted the pr-target-build branch November 7, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant