Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended delta API #440

Merged
merged 4 commits into from
Mar 15, 2022
Merged

Extended delta API #440

merged 4 commits into from
Mar 15, 2022

Conversation

fo-code
Copy link
Contributor

@fo-code fo-code commented Mar 14, 2022

I implemented the new delta extension of the Forensics API Plugin for Git. The code delta can now be calculated between two Jenkins builds.

@uhafner uhafner added the enhancement Enhancement of existing functionality label Mar 14, 2022
Copy link
Member

@uhafner uhafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that I did not spot this problem before...

That means forensics-api need another change:

public Optional<Delta> calculateDelta(final Run<?, ?> build, final Run<?, ?> referenceBuild,
             final String scmKeyFilter, final FilteredLog logger) {

Do we need the other methods still in the API? Then we can remove them and ignore the errors in RevAPI.

plugin/pom.xml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #440 (9f947c9) into master (cc1156b) will increase coverage by 0.03%.
The diff coverage is 85.71%.

❗ Current head 9f947c9 differs from pull request most recent head 864bf4b. Consider uploading reports for the commit 864bf4b to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #440      +/-   ##
============================================
+ Coverage     81.94%   81.97%   +0.03%     
- Complexity      194      196       +2     
============================================
  Files            26       26              
  Lines           781      788       +7     
  Branches         82       83       +1     
============================================
+ Hits            640      646       +6     
  Misses          110      110              
- Partials         31       32       +1     
Impacted Files Coverage Δ
...lugins/forensics/git/delta/GitDeltaCalculator.java 89.47% <85.71%> (-2.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc1156b...864bf4b. Read the comment docs.

plugin/pom.xml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants