Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not show stack trace when printing a missing commit #1393

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Do not show stack trace when printing a missing commit #1393

merged 1 commit into from
Jan 11, 2023

Conversation

MarkEWaite
Copy link
Contributor

Do not show stack trace when printing a missing commit

A missing commit message is not sufficient to justify the distraction of a stack trace in the log. State that the commit message cannot be displayed because the commit cannot be found.

Checklist

  • I have read the CONTRIBUTING doc
  • I have referenced the Jira issue related to my changes in one or more commit messages
  • I have added tests that verify my changes
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No Javadoc warnings were introduced with my changes
  • No spotbugs warnings were introduced with my changes
  • Documentation in README has been updated as necessary
  • Online help has been added and reviewed for any new or modified fields
  • I have interactively tested my changes
  • Any dependent changes have been merged and published in upstream modules (like git-client-plugin)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

@MarkEWaite
Do not show stack trace on missing commit
01c2e33 
A missing commit message is not sufficient to justify the distraction
of a stack trace in the log.  State that the commit message cannot be
displayed because the commit cannot be found.
@MarkEWaite MarkEWaite added the bugfix Fixes a bug - used by Release Drafter label Jan 11, 2023
@MarkEWaite MarkEWaite merged commit 22f8ceb into jenkinsci:master Jan 11, 2023
@MarkEWaite MarkEWaite deleted the clarify-missing-commit-message branch January 11, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix Fixes a bug - used by Release Drafter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MarkEWaite