Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable SCMTriggerTests #1449

Merged
merged 3 commits into from
May 6, 2023

Conversation

MarkEWaite
Copy link
Contributor

Enable SCMTriggerTests

The tests were disabled because they caused releases in 2016 to require an hour or more. Newer hardware runs faster and time limiting options in tests may allow more of them to run without affecting the time to release the plugin.

  • Remove test that was disabled in 2016
  • Time limit SCMTriggerTest on Linux
  • Allow up to 2 minutes for SCMTriggerTest

Checklist

  • I have read the CONTRIBUTING doc
  • I have referenced the Jira issue related to my changes in one or more commit messages
  • I have added tests that verify my changes
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No Javadoc warnings were introduced with my changes
  • No spotbugs warnings were introduced with my changes
  • Documentation in README has been updated as necessary
  • Online help has been added and reviewed for any new or modified fields
  • I have interactively tested my changes
  • Any dependent changes have been merged and published in upstream modules (like git-client-plugin)

Types of changes

  • Test

Assumes it is allowed to modify the list of refspecs directly inside the
job definition.  Lists inside the job definition should not be modifiable
by external callers.
More tests are a good thing so long as they don't waste too much time
Long enough to run 1 test, not enough for whole suite
@MarkEWaite MarkEWaite added the test label May 6, 2023
@github-actions github-actions bot removed the test label May 6, 2023
@MarkEWaite MarkEWaite added the test label May 6, 2023
@MarkEWaite MarkEWaite enabled auto-merge (rebase) May 6, 2023 03:52
@MarkEWaite MarkEWaite merged commit 0302159 into jenkinsci:master May 6, 2023
@MarkEWaite MarkEWaite deleted the enable-scm-trigger-tests branch May 6, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant