Some Cleanup and Refactoring #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @7FM, thank you for your contribution. A side note here: it's really difficult to review your PR as you mixed code refactoring, code cleanup and a bug fix. If the first two can coexist in a PR, the third should be treated separately. |
7FM
changed the title
|
I see the inconveinience here... Sorry for that. I split the PR as suggested (See: #17) |
|
Thank you very much for taking the time to do so. |
stephenc
suggested changes
Nov 21, 2019
src/main/java/org/jenkinsci/plugin/gitea/AbstractGiteaSCMSourceEvent.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jenkinsci/plugin/gitea/client/api/GiteaConnection.java
Outdated
Show resolved
Hide resolved
This reverts commit e5c0c15.
|
This time I tried to not touch any throws statements |
stephenc
approved these changes
Nov 21, 2019
|
Can you also update CHANGES.md and we’ll see what the final CI status before merging (with merge commit) |
stephenc
approved these changes
Nov 21, 2019
|
Anything left to do? |
justusbunsi
pushed a commit
to justusbunsi/gitea-plugin
that referenced
this pull request
Jul 3, 2021
jenkinsci#15) Co-authored-by: Renovate Bot <bot@renovateapp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding the cleanup: I am not sure why there where as many throws statements that intellij marks to be not needed... Am I missing something here? Maybe some Jenkins Plugin related stuff? If so I will have to partially undo the cleanup. Please let me know.