FIX JENKINS-63048

[hoolie]

use the ref=next link in the response header to support paged requests.

The response header received in getList contains a link to the next page, getList is called recursive with the new URL.

FIX https://issues.jenkins.io/browse/JENKINS-63048

[MarkEWaite]

I'd love to test drive your changes. Unfortunately, I can't build the source code and the CI job can't build the source code.

When I try to build with Java 8u302, it reports

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project gitea: Compilation failure
[ERROR] /home/mwaite/hub/plugins/gitea-plugin/src/main/java/org/jenkinsci/plugin/gitea/client/impl/DefaultGiteaConnection.java:[966,64] illegal escape character

When I try to build with Java 11.0.12, it reports:

[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /home/mwaite/hub/plugins/gitea-plugin/src/main/java/org/jenkinsci/plugin/gitea/client/impl/DefaultGiteaConnection.java:[966,64] illegal escape character
[INFO] 1 error

[MarkEWaite]

Thanks so much for your quick response @hoolie !

May also need an addition to pom.xml:

    <repositories>
        <repository>
            <id>repo.jenkins-ci.org</id>
            <url>https://repo.jenkins-ci.org/public/</url>
        </repository>
    </repositories>
    <pluginRepositories>
        <pluginRepository>
            <id>repo.jenkins-ci.org</id>
            <url>https://repo.jenkins-ci.org/public/</url>
        </pluginRepository>
    </pluginRepositories>

Master branch of that repo was last built a year ago. Apache maven 3.8.2 upgrade and recent infrastructure may be causing that pom.xml gap to be detected.

[hoolie]

Hello Mark,

It fixed a missing escape character in the regexp.
I'm still trying to figure out why that error did not cause my build to fail.

Thanks for the pom-update

[MarkEWaite]

Same build problem is visible on the master branch at https://ci.jenkins.io/job/Plugins/job/gitea-plugin/job/master/88/ . I don't see that problem locally, but I suspect that is because I have a locally cached copy of the dependency that is causing the failure.

[MarkEWaite]

@hoolie I've added the incremental build of the plugin to my installation. The first pipeline scan detected the 100+ branches that had been missed in previous scans when the scanning stops with the first 30 results.

I'll continue using it to see if I detect any issues with it. Thanks so much for the pull request!

[hoolie]

glad it helped :)

is there currently another maintainer for the plugin besides @stephenc ?

[MarkEWaite]

According to repository permissions updater, he's the only maintainer. I don't know his current availability. If he's unavailable, you could propose to become an additional maintainer of the plugin if you're willing.

The incremental build from ci.jenkins.io can be used by anyone who needs the functionality immediately.

[lafriks]

I created issue some time ago to transfer plugin maintainence to gitea developers but no response yet there also https://issues.jenkins.io/plugins/servlet/mobile#issue/JENKINS-65588

[MarkEWaite]

@lafriks that issue report won't result in any action. The Jenkins project "adopt a plugin" process requires the jenkins.io user names of one or more maintainers. You asked:

Would it be possible to add Gitea owners/main maintainers rights to approve PRs, merge them and create releases in https://github.com/jenkinsci/gitea-plugin repository?

The answer to that question is, "Yes, if a person with a jenkins.io account is willing follow the 'adopt a plugin' process, they can be granted permission to merge pull requests and deliver new releases".

Who are the Gitea owners/main maintainers?

Are they willing to maintain the Jenkins Gitea plugin?

What are their jenkins.io account user names?

Will they follow the "adopt a plugin" process so that they can be assigned as maintainers?

[hoolie]

@MarkEWaite Thank you for the insights on the "adopt a plugin" process

I don't fell ready to take on responsibility for the plugin yet for the following reasons:

• I don't have the required spare time
• I wouldn't want to review my own PR
• I lack experience with the Jenkins plugin system / SCM Api

[lafriks]

@MarkEWaite thanks for detailed info.

Gitea owners are 3 of the maintainers elected each year from Gitea active maintainers (https://github.com/go-gitea/gitea/blob/main/MAINTAINERS). Currently Gitea owners are me, @techknowlogick and @lunny.

As for adopting plugin, I'm quite sure most of them don't have jenkins.io accounts but that would not be an issue to create it but otherwise we could at least review PRs and manage releases as we are interested in working Gitea integration with Jenkins. Gitea currently has process that at least two of maintainers has to approve PR to have it merged, and only owners or some limited number of maintainers that are allowed to tag releases, so we would follow same procedure here.

[melmus]

Hi! When will new version plugin release?

[den-patrakeev]

Hello!
Agree with @melmus
Now I have problems with displaying branches.

[MarkEWaite]

@melmus and @den-patrakeev you can use the incremental build of this pull request now. No need to wait for a release of the plugin. See my comment #31 (comment) . It helps the maintainers when users declare "I'm using this pull request successfully in my production environment".

I am using it successfully in my production environment. It works great.

Download the latest hpi file from https://ci.jenkins.io/job/Plugins/job/gitea-plugin/job/PR-31/ and upload it to your Jenkins installation through the plugin manager. If you're using configuration as code, then my plugins.txt file shows how to specify that version.

[den-patrakeev]

@MarkEWaite Thank you for your prompt response!

[melmus]

@MarkEWaite, thank's for you answer!

[lafriks]

Tested and works for me, thanks for great work and tests!