Make plugin compatible with Job DSL

[LEDfan]

Hi

First of all, a big thanks for picking up maintenance for this plugin again!

We are using this plugin with an initial root job using the job DSL. The current version of the plugin has two problems regarding DSL support:

• it is impossible to configure the traits of giteaSCMNavigator
• it is impossible to configure the giteaForkDiscovery trait

This PR adds full support for configuration via the Job DSL plugin.

Fixes:

• https://issues.jenkins.io/browse/JENKINS-66584
• https://issues.jenkins.io/browse/JENKINS-64580

[justusbunsi]

Thanks for the PR. I'll test drive the changes in the next days.

[justusbunsi]

Hi @LEDfan. I've tested your changes and now it's really easy to configure traits. 👍
There would be just a few additional changes needed to have full Job DSL support - at least as far as it can be done within this plugin. It would also fix a few issues:

• https://issues.jenkins.io/browse/JENKINS-66584
• https://issues.jenkins.io/browse/JENKINS-64580

If you could add those changes to your PR as well, this would be awesome. Otherwise, I'll create an additional PR based on your changes. Please let me know how we proceed.

The changes would be...

• Add @Symbol("gitea") to GiteaSCMNavigators DescriptorImpl
• Fix upper/lower case typo in Symbol annotation of OriginPullRequestDiscoveryTrait
• Add @Symbol("giteaSSHCheckout") to SSHCheckoutTraits DescriptorImpl
• Add @Symbol("giteaTagDiscovery") to TagDiscoveryTraits DescriptorImpl
• Add @Symbol("giteaWebhookRegistration") to WebhookRegistrationTraits DescriptorImpl

...to achieve a configuration like the following.

organizationFolder('gitea-org') {
  displayName('This is my Gitea organization')
  organizations {
    gitea {
      serverUrl("https://git.example.com")
      repoOwner("owner")
      credentialsId("gitea-token-credentials")

      traits {
        // Repository filter
        sourceWildcardFilter {
          includes("gitea-plugin")
          excludes("")
        }

        // Branch/Tag/PR filter
        headRegexFilter {
          regex("^(main|develop\\/.*|v\\d+|PR-.*)\$")
        }
        giteaExcludeArchivedRepositories {}
        giteaTagDiscovery {}
        giteaSSHCheckout {
          credentialsId('ssh-gitea')
        }
        giteaBranchDiscovery {
          strategyId(1)
        }
        giteaPullRequestDiscovery {
          strategyId(1)
        }
        giteaForkDiscovery {
          strategyId(1)
          trust {
            giteaTrustContributors {}
            // giteaTrustEveryone {}
            // giteaTrustNobody {}
          }
        }

        // Override webhook management
        giteaWebhookRegistration {
          mode('ITEM')
          // mode('DISABLED')
        }
      }
    }
  }
}

[LEDfan]

Thanks @justusbunsi for the additional fixes, I integrated them into this PR.

[justusbunsi]

LGTM. Thanks for your addition to the plugin. 🤗

[justusbunsi]

FYI, I've updated the PR description to match the actual changes.