Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Displays the repository avatar in Jenkins #49

Merged
merged 8 commits into from
Apr 29, 2022

Conversation

kins-dev
Copy link
Contributor

@kins-dev kins-dev commented Mar 1, 2022

Pulls the avatar image from the gitea server and displays it in Jenkins. Useful for Organization Folder type projects.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
    • N/A - Issues are enabled in GitHub, at least none I could find
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue
    • N/A - UI based, while I could make a mock URL, this wouldn't demonstrate the feature

@justusbunsi
Copy link
Member

Hi. Thanks for your contribution. Could you give me a hint, where the avatars were missing? I'm seeing avatars being loaded from Gitea already with the current plugin version.

@justusbunsi
Copy link
Member

Nevermind. Your PR is for repository avatars. I got confused with organization avatars that I always see. Sorry for that.

Will have a closer look at this the next days.

Copy link
Member

@justusbunsi justusbunsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite the getDisplayName() addition @lafriks already mentioned: LGTM.

@lafriks lafriks merged commit e0817df into jenkinsci:master Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants