[FIXED JENKINS-41616] Non-trusted pull requests should use a probe against the trusted revision not the PR's revision #128
Conversation
…ainst the trusted revision not the PR's revision
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
|
🐝 |
There was a problem hiding this comment.
Fine as it is, but will just need to be thrown out for #96, at which point reimplementing it would pay a small performance penalty.
I am not even convinced we want to fix this this way. Simply ignoring someone’s PR to add a Jenkinsfile could be more confusing than the current state, where we at least schedule a build that fails and sets a corresponding status failure—so you know the PR needs to be refiled by a trusted user. This in fact happened to me recently.
See JENKINS-41616
@reviewbybees