Not building origin merge when webhook is received.

[tecnobrat]

This looks like a simple typo, as its different (and the logic seems correct) here:

github-branch-source-plugin/src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java

Lines 642 to 644 in f4403ae

	if (buildOriginPRHead) {
	branchName += "-merge";
	}

[kzantow]

This LGTM; need to get maintainers to approve it, though.

[rsandell]

LGTM 👍

[tecnobrat]

@stephenc is there any way we can get a new version built for this? Thanks!

[stephenc]

It's after 5:30pm on a Friday! Aint going to happen this side of the weekend 😜

[tecnobrat]

But I opened this 12 hours ago!

Didn't realize you were in Ireland ;) Only 10:30am over here.

[michaelneale]

OMG outstanding catch!

@tecnobrat the benefit of timezones is that at leaast you get it before your monday.

🍺

[jglick]

FTR looks like this was broken since its introduction in #93, so not a regression as such.

[tecnobrat]

@stephenc any chance we can get a release on this? :)

Its blocking our workflows :) Thanks!

[stephenc]

2.0.5 on the way

[stephenc]

Should be released now but thanks to https://issues.jenkins-ci.org/browse/INFRA-1135 I cannot update the wiki with the release notes

[drehelis]

Updated today and it seems like bunch of PRs were indexed with no Jenkinsfile in the code.
But index says "Jenkinsfile found"...

Checking pull request #1644
(not from a trusted source)
Job name: PR-1644
  ‘Jenkinsfile’ found
  Not mergeable, but will be built anyway
Met criteria

No changes detected: PR-1644 (still at xxxx)

Could be related?

[stephenc]

@autogun if it is not from a trusted source then the Jenkinsfile will come from the target branch not the PR itself... Also the Jenkins JIRA is a better place to comment as attaching comments to a merged PR is typically just as effective as using

echo "Description of my issue" >> /dev/null

The only reason I saw this was because the tab was still open and I was closing it... once it had been closed your comment would have ended up in /dev/null. Please use the Jenkins JIRA in future