Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using checkMethod on c:select #151

Merged
merged 3 commits into from
Sep 8, 2017
Merged

Conversation

jglick
Copy link
Member

@jglick jglick commented Aug 8, 2017

Downstream of jenkinsci/credentials-plugin#90. Analogue of jenkinsci/subversion-plugin#192.

@reviewbybees

@ghost
Copy link

ghost commented Aug 8, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@jglick jglick requested a review from stephenc August 15, 2017 12:41
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐝

@jglick
Copy link
Member Author

jglick commented Aug 17, 2017

@reviewbybees done

@stephenc
Copy link
Member

Needs updating and the upstream release but LGTM

@jglick jglick merged commit 14d43ef into jenkinsci:master Sep 8, 2017
@jglick jglick deleted the checkMethod branch September 8, 2017 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants