Added Branch unit tests #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 24, 2019 13:11
Added some LazyBranch iterator tests to make sure all code paths are tested out and each is commented with what it is doing
Apparently my new json files were breaking existing `branch` tests and that was causing build failures. I moved the branch json files out to another folder and adjusted my new tests to use them
|
Failing with an out of heap space on windows agents. I dont think that is my fault though... |
bitwiseman
approved these changes
Oct 31, 2019
I realized I was not using the mappings to begin with so I removed them and then removed other stubs that were excessive and unused
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some LazyBranch iterator tests to make sure all code paths are tested out and each is commented with what it is doing