Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-60413] Guard against PRs from unknown forks #261

Merged
merged 2 commits into from
Dec 19, 2019
Merged

[JENKINS-60413] Guard against PRs from unknown forks #261

merged 2 commits into from
Dec 19, 2019

Conversation

Dohbedoh
Copy link
Contributor

  • JENKINS issue(s):
  • Description:
    • Indexing fails when there are open PRs from unknown forks (for example deleted forks)
  • Documentation changes:
    • N/A
  • Users/aliases to notify:

@Dohbedoh
Copy link
Contributor Author

I am trying to reconcile both JENKINS-58450 and JENKINS-41246 by passing this.sourceOwner. This should fix the regression and be aligned with the previous behavior for deleted forks. I am open to suggestions though.

@Dohbedoh Dohbedoh changed the title [JENKINS-60413] Test scenario for unknown fork [JENKINS-60413] Guard against PRs from unknown forks Dec 10, 2019
@Dohbedoh
Copy link
Contributor Author

Tested that it fixes the indexing and that it is considered as an untrusted source:

Checking pull request #1937
    (not from a trusted source)
    Met criteria

@aheritier
Copy link
Member

(I removed my previous comment. This is the repo from head which is null not the one from base. It's ok for me

@bitwiseman bitwiseman merged commit 5667298 into jenkinsci:master Dec 19, 2019
@Dohbedoh Dohbedoh deleted the JENKINS-60413 branch December 30, 2019 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitwiseman bitwiseman bitwiseman approved these changes

@aheritier aheritier aheritier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dohbedoh @aheritier @bitwiseman