Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos #277

Merged
merged 1 commit into from
Feb 6, 2020
Merged

Fix typos #277

merged 1 commit into from
Feb 6, 2020

Conversation

darxriggs
Copy link
Contributor

No description provided.

@darxriggs
Copy link
Contributor Author

I rebased on master and fixed the merge conflict.

dwnusbaum
dwnusbaum approved these changes Feb 6, 2020
View reviewed changes
Copy link
Member

@dwnusbaum dwnusbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me. I might revert the change to DesciptorImpl just to be conservative, but it is probably not an issue.

src/main/java/org/jenkinsci/plugins/github_branch_source/Endpoint.java Show resolved Hide resolved
src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java Show resolved Hide resolved
@darxriggs
Copy link
Contributor Author

I would like that we are not too conservative and fix the typo in the descriptor.

@bitwiseman bitwiseman merged commit 51a0e7f into jenkinsci:master Feb 6, 2020
@darxriggs darxriggs deleted the fix-typos branch February 6, 2020 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitwiseman bitwiseman bitwiseman approved these changes

@dwnusbaum dwnusbaum dwnusbaum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@darxriggs @dwnusbaum @bitwiseman