Update to plugin-pom 3.57 #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
approved these changes
Apr 3, 2020
| * | ||
| * @param apiUri the api uri | ||
| */ | ||
| @Restricted(NoExternalUse.class) |
There was a problem hiding this comment.
unnecessary for a non-public member
| source.setApiUri("http://localhost:" + githubApi.port()); | ||
| } | ||
| // force apiUri to point to test server | ||
| source.forceApiUri("http://localhost:" + githubApi.port()); |
There was a problem hiding this comment.
Related to parent update somehow?
There was a problem hiding this comment.
I'm not sure how these tests ever passed and they were failing on my machine. I had to update to get to a passing build.
I'm not really sure how these ever worked.
bitwiseman
force-pushed
the
task/plugin-pom
branch
from
f22ffb5
to
dd09071
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update to plugin-pom 3.57. Fixes to tests.
Submitter checklist
Reviewer checklist
Documentation changes
Users/aliases to notify