Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[JENKINS-71849] Allow NoThrottle to be used even on github.… #730

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

car-roll
Copy link
Contributor

@car-roll car-roll commented Sep 18, 2023

…com (#653)"

This reverts commit 51d5810.

Description

Reverting #653 due to concerns of GitHub policies explained here: #653 (comment)

Issue experienced in JENKINS-71849 still exist and need continued investigation as to why ThrottleOnOver is not behaving as expected.

Submitter checklist

  • Link to JIRA ticket in description, if appropriate.
  • Change is code complete and matches issue description
  • Automated tests have been added to exercise the changes
  • Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.

Reviewer checklist

  • Run the changes and verify that the change matches the issue description
  • Reviewed the code
  • Verified that the appropriate tests have been written or valid explanation given

Documentation changes

  • Link to jenkins.io PR, or an explanation for why no doc changes are needed

Users/aliases to notify

@car-roll car-roll requested a review from a team as a code owner September 18, 2023 16:13
@car-roll car-roll added the bug label Sep 18, 2023
@car-roll car-roll merged commit a3028eb into jenkinsci:master Sep 18, 2023
spotoczny pushed a commit to smartrecruiters/github-branch-source-plugin that referenced this pull request Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants