[JENKINS-73053] Allow users with Overall/Manage permission to configure endpoints #784
Conversation
…re endpoints See [JENKINS-73053](https://issues.jenkins.io/browse/JENKINS-73053).
|
Do I get it right that this only fixes permission checks on form validation and dropdowns and that the actual submission of a new endpoint was already allowed? |
|
I was missing a |
| @@ -90,6 +91,13 @@ public void canPostAsAdmin_doCheckApiUri() throws Exception { | |||
| assertTrue(TestRoot.get().visited); | |||
| } | |||
|
|
|||
| @Test | |||
| @Issue("JENKINS-73053") | ||
| public void manageCanSetupEndpoints() throws Exception { | ||
| HtmlPage htmlPage = j.createWebClient().login("alice").goTo("manage/configure"); | ||
| assertTrue(htmlPage.getVisibleText().contains("GitHub Enterprise Servers")); |
There was a problem hiding this comment.
Does not verify that you can actually save new endpoints, but that is much harder to test in WebClient (given YUI craziness), and I guess ought to be implied by the same getRequiredGlobalConfigPagePermission. Did you at least try it interactively? (Most easily by just setting a breakpoint in this test and then logging in as alice / alice from a real browser.)
There was a problem hiding this comment.
Verified manually. It works as expected.
Description
Allow users with Overall/Manage permission to configure endpoints. See JENKINS-73053 for further information.
Submitter checklist
Reviewer checklist
Documentation changes
Users/aliases to notify