Jenkins Plugin not able to retrieve infomation about user behind proxies requiring authentication #143
+183
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g authentication If we configure the Jenkins server to be used behind a proxy which requires authentication, then Jenkins authentication plugin becomes unusable. The reason for that is the fact that configured username and password are not passed into the httpclient from Jenkins configuration. To reproduce this error do following: - Start Jenkins server behind proxy requiring authentication - Configure the gihub authentication plugin - Clear your browser cookies - Try to login - Observe the login looping due to missing access token This commit fixes the issue.
…nce the latter causes an infinite loop
|
Please make a new plugin release once this is merged, because our team is blocked in our Jenkins migration by this issue. Thank you in advanced. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the usage of github authentication plugin behind proxies requiring authentication
If we configure the Jenkins server to be used behind a proxy which requires
authentication, then Jenkins authentication plugin becomes unusable. The
reason for that is the fact that configured username and password are not
passed into the httpclient from Jenkins configuration.
To reproduce this error do following:
This PR fixes the issue.