Update the plugin for OAuth #25
Conversation
|
Jenkins » github-plugin #31 FAILURE |
|
Jenkins » github-plugin #32 FAILURE |
|
That's going to continue to fail until hub4j/github-api#33 is merged and released. |
| GitHub gitHub; | ||
| if (Util.fixEmpty(apiUrl) != null) { | ||
| gitHub = GitHub.connectToEnterprise(apiUrl,username,apiToken); | ||
| gitHub = GitHub.connectToEnterprise(apiUrl,username,oauthAccessToken); |
There was a problem hiding this comment.
Should probably be GitHub.connectToEnterprise(apiUrl,oauthAccessToken) to match login()
There was a problem hiding this comment.
Thanks for the review! I'm pretty swamped with work at the moment, but will take a look once I'm able to surface for some air.
There was a problem hiding this comment.
I can confirm that it should be GitHub.connectToEnterprise(apiUrl,oauthAccessToken) I made that change locally and saw everything with my github enterprise start working
|
github-api-1.42 now includes the required fix |
|
https://issues.jenkins-ci.org/browse/JENKINS-17240 Also, updating to github-api-1.42 and making these changes makes everything work nicely. |
|
Jenkins » github-plugin #40 FAILURE |
|
Jenkins » github-plugin #41 SUCCESS |
|
Looks like we're good to go here! @kohsuke could you take a look? |
This updates the plugin to reference OAuth tokens rather than the old deprecated API tokens and is dependent on the changes in hub4j/github-api#33.