Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spaces in Jenkins job name causes CI Status to not update #85

Closed
ndcampbell opened this issue May 29, 2015 · 3 comments
Closed

Spaces in Jenkins job name causes CI Status to not update #85

ndcampbell opened this issue May 29, 2015 · 3 comments

Comments

@ndcampbell
Copy link

I am getting the error "Cannot connect to the CI server." on Merge Requests in Gitlab ever since upgrading to 7.10.5-ee. This is happening for any project where my Jenkins job name has a space in it. The projects still build and everything, just the status says it cannot connect. If I remove spaces from the job name, it works. This was working just fine in 7.10.0-ee.

I am using the most recent version of the plugin. I checked the production.log in gitlab and see:

Started GET "/venus-platform/venus/merge_requests/165/ci_status" for 127.0.0.1 at 2015-05-29 08:17:36 -0500

and in the Jenkins log I see:

May 29, 2015 8:21:58 AM com.dabsquared.gitlabjenkins.GitLabWebHook getDynamic
INFO: WebHook called with url: /refs/bug-changeBgcEnumToEspd/commits/97b19a8d6a6cb52c8faaf6f55588270dadbc3a33/status.json

Any ideas?

Jenkins URLs use "%20" for spaces. Perhaps a parsing error?

image

@ndcampbell ndcampbell changed the title "Cannot connect to the CI server." error on all but one project Spaces in Jenkins job name causes CI Status to not update May 29, 2015
@thatarchguy
Copy link

+1 I experienced this as well.

@omehegan omehegan added the bug For changelog: Minor bug. Will be listed after features label Feb 25, 2016
@omehegan
Copy link
Member

Confirmed, still a bug in the latest version.

@coder-hugo
Copy link
Contributor

This is a bug in GitLab 7.14. It forces you to enter a valid URL that contains slashes already URL encoded (%20) but does an URL encoding itself before requesting the status.json. This second URL encoding changes the % sign to %25. As the Jenkins does the URL decoding just once (for a reason) the gitlab-plugin gets a project name that contains a %20 instead of a space.
I'd suggest you to use URL friendly names (names that not contain any sign that needs to be URL encoded) for your Jenkins jobs. If you like to have a more human readable name for the job in the overview page use the displayName of the advanced project options for this.

@coder-hugo coder-hugo added wontfix and removed bug For changelog: Minor bug. Will be listed after features labels Feb 27, 2016
exceed-alae pushed a commit to exceed-alae/gitlab-plugin that referenced this issue May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants