Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a job-level configuration parameter alwaysForceBuild. #1001

Closed

Conversation

interone-ms
Copy link

This parameter allows overriding the check isLastCommitNotYetBuild in MergeRequestHookTriggerHandlerImpl.

This commit fixes issue #636 and #734, probably also #958.

Notice: I am not a Java expert, especially not in writing test code, so I would be happy if someone could please add a test for the new feature. Existing tests do not break and regular operations in our Jenkins also work so I am at least confident that no regressions have been introduced.

This parameter allows overriding the check isLastCommitNotYetBuild in MergeRequestHookTriggerHandlerImpl.

This commit fixes issue jenkinsci#636 and jenkinsci#734, probably also jenkinsci#958.
@ghost
Copy link

ghost commented Mar 12, 2021

Hi
Resolve you conflict and after I look your code

thanks a lot

@ghost ghost closed this May 14, 2021
@th3br0
Copy link

th3br0 commented Nov 21, 2022

Hello there,
how come this has not been integrated? This would be so incredibly useful.

@MarkEWaite
Copy link
Contributor

Hello there, how come this has not been integrated? This would be so incredibly useful.

Because there was a conflict between the proposed pull request and the code on the primary branch. A request was made to resolve the conflict. That request was unheeded for 2 months. The maintainer closed the pull request.

You could certainly take the original proposal, rebase it on the primary branch, and submit a new pull request. You could then use the incremental build of that feature yourself and offer the results to others as well.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants