Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger builds when MR is approved #659

Merged
merged 1 commit into from
Nov 13, 2017

Conversation

jakub-bochenski
Copy link
Contributor

@jakub-bochenski jakub-bochenski commented Nov 6, 2017

The builds are not triggered because parsing of the action field fails.

I can't find this field being actually read anywhere, hence no automated tests.

I verified manually that this works using our staging Jenkins instance and gitlab 10.0.4-ee

@jakub-bochenski jakub-bochenski changed the title WIP: Trigger builds when MR is approved Trigger builds when MR is approved Nov 6, 2017
@marcinmantke
Copy link

Is there any ETA when this will be merged and released?

@omehegan omehegan merged commit a4ac366 into jenkinsci:master Nov 13, 2017
@omehegan
Copy link
Member

Thanks!

@omehegan
Copy link
Member

This has just been released in plugin version 1.5.2. It will be in the update center within a few hours.

exceed-alae pushed a commit to exceed-alae/gitlab-plugin that referenced this pull request May 20, 2022
remove extra msg comments for build comment file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants