chore: Add servlet-api to testCompile scope

[rahulsom]

See: #235 (comment)

This adds servlet-api to the testCompile scope to allow compilation of certain types to succeed in test code.

Testing done

Submitter checklist

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

[basil]

Check the testHarnessFor method a few lines down. For 2.475+ the latest test harness should be used, which bundles Jetty 12 and EE 9.

[rahulsom]

Here's the change to use a newer jenkins-test-harness - rahulsom#8.
It's stacked on this one.

[rahulsom]

@basil do you know if there's something to tickle on the CI infra to get those two checks to run?

[rahulsom]

Actually, this might be an @sghill thing. Are the "Required builds" set incorrectly on the repo?

[basil]

I don’t see why this PR would be necessary. The test harness declares all of its transitive dependencies correctly, so including the correct test harness should suffice.

[sghill]

Are the "Required builds" set incorrectly on the repo?

The two checks will run once #242 is merged and opened PRs are rebased. I updated the default branch recently.

The test harness declares all of its transitive dependencies correctly, so including the correct test harness should suffice.

I'm OK with closing this one out pulling in the test harness (#239) instead. What do you think, @rahulsom?

[rahulsom]

Let's keep it open until the issue Basil reported is resolved with the other PR.