✨ Fixed #JENKINS-44586. add support for managing credentials #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @khmarbaise |
wei-lee
force-pushed
the
JENKINS-44586-credential-support
branch
from
20134e1
to
01d8cda
Compare
| @@ -33,12 +33,12 @@ public void getPluginsShouldReturn9ForJenkins20() { | |||
| } | |||
|
|
|||
| @Test | |||
| public void getPluginsShouldReturn27ForJenkins1651() { | |||
| public void getPluginsShouldReturn28ForJenkins1651() { | |||
| JenkinsVersion jv = jenkinsServer.getVersion(); | |||
| if (jv.isLessThan("1.651") && jv.isGreaterThan("1.651.3")) { | |||
There was a problem hiding this comment.
Should this not be an or instead of an and?
There was a problem hiding this comment.
@aidenkeating not really sure TBH. I didn't write this test. Just update the name of the test as I added a new plugin
wei-lee
force-pushed
the
JENKINS-44586-credential-support
branch
from
70fa366
to
8058758
Compare
|
any reason those changes are not merged ? we are currently in the process of releasing a fork, IMO it would be much more value to the larger community if
Is there anything we can help to make that happen ? |
wei-lee
force-pushed
the
JENKINS-44586-credential-support
branch
from
8058758
to
b320380
Compare
|
my not merge this, i need credentials manage too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace #256. This time with the right JIRA issue in the commit message.