Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable spotless again #109

Merged
merged 1 commit into from
Aug 13, 2023
Merged

Conversation

MarkEWaite
Copy link
Contributor

Enable spotless again

Parent pom 4.72 is needed for spotless on Java 21.

Thanks @NotMyFault for detecting my issue!

Testing done

Confirmed that mvn spotless:apply works as expected on the pom.xml file and on Java files with Java 21 early access.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Needs parent pom 4.72 or newer
@MarkEWaite MarkEWaite requested a review from a team as a code owner August 13, 2023 12:44
@MarkEWaite MarkEWaite merged commit 7509ed3 into jenkinsci:master Aug 13, 2023
16 checks passed
@MarkEWaite MarkEWaite deleted the enable-spotless-again branch August 13, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant