Fixed some problems with tag lib generation #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I understand that you are pretty busy. But would it be possible to give some feedback, so that we can decide how to move on? Thanks in advance. |
When the plugin is executed in a project of type pom it throws an exception because it cannot find the source directory. This is now suppressed, and no data is generated for this project. The use case is that there can be multi-module projects defining multiple tag libs. Then it makes sense to have a parent project (of type pom) which configures the plugin. The plugin is then applied to all taglib sub projects. With this patch, this use case is now supported.
If a tag library contained abstract base classes for tags, the plugin failed with a NPE in ReferenceRenderer. In this constellation, the XML schema document contained an empty element without attributes. This has been fixed by checking for an abstract tag before adding an element to the library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I am a member of the Apache Commons team, and currently I try to do some maintenance work on the Apache Commons Jelly component. A prerequisite for getting out a new release is to get the site build working again. The build uses the maven-jellydoc-plugin to generate the documentation for the various standard tag libs shipped with Jelly. Unfortunately, I hit two major problems:
It would be great if the PR was merged and a new release could be published.
Many thanks!
Oliver