Require Java 11 or newer #60
Conversation
|
@NotMyFault Are you interested in helping me test this? Would be great to run core taglib generation against this change and verify that the taglibs look right (or at least no worse than before). |
|
|
||
| private String targetFileName = null; | ||
| private String encodingFormat; | ||
|
|
||
| public TagXMLDoclet (RootDoc root) throws Exception | ||
| private void main(DocletEnvironment root) throws Exception |
There was a problem hiding this comment.
Good luck trying to understand the changes to this file. The only migration guide that exists has almost zero information other than the package changes. I had to figure out all of the semantic changes by trial and error.
Surely, I created https://github.com/NotMyFault/jenkins/tree/jellydoc-11 with an incremental of maven-stapler-plugin using an incremental of this PR. The generated page looks like https://reports.jenkins.io/core-taglib/jelly-taglib-ref.html |
|
Great! So are we ready to move forward with this? |
| @@ -28,7 +28,7 @@ jobs: | |||
| uses: actions/setup-java@v3 | |||
| with: | |||
| distribution: 'temurin' | |||
| java-version: '8' | |||
| java-version: '11' | |||
There was a problem hiding this comment.
We probably can use 17 too, no?
There was a problem hiding this comment.
We could, but that would be inconsistent with the Stapler and HPI Maven plugins.
Fixes #38. Migrates away from the Java 8 Javadoc API to the Java 9+ Javadoc API. I could not find any reference material online; this was all learned as I went.
Testing done
Ran the Mojo before and after this change against Jelly; verified that the generated taglibs looked right.
Submitter checklist