-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use non-deprecated Sink
class
#7
Conversation
My build fails with
Note that I am using
@michael-osipov Is there a way for me to make Maven Jellydoc Plugin forward compatible with Maven Site Plugin 4, while continuing to have a primary target (and actual usage) of Maven Site Plugin 3? |
Happy New Year @michael-o. Is there a way for me to make Maven Jellydoc Plugin forward compatible with Maven Site Plugin 4, while continuing to have a primary target (and actual usage) of Maven Site Plugin 3? |
Why do you use impl if you don't implement AbstractMavenReport? In your case you should implement similarly I did with Maven Javadoc Plugin, the you don't need impl since you have a hybrid plugin. |
I did a case-insensitive search for the string |
But you depend on it. You can safely remove it first |
Here "it" is a pronoun whose antecedent is "impl". I searched |
Thanks Michael, I had missed that in my search because I was only looking in the root directory. I tried doing what you suggested via diff --git a/maven-jellydoc-plugin/pom.xml b/maven-jellydoc-plugin/pom.xml
index 9d65729..0613a26 100644
--- a/maven-jellydoc-plugin/pom.xml
+++ b/maven-jellydoc-plugin/pom.xml
@@ -136,14 +136,8 @@
</dependency>
<dependency>
<groupId>org.apache.maven.reporting</groupId>
- <artifactId>maven-reporting-impl</artifactId>
- <version>3.2.0</version>
- <exclusions>
- <exclusion>
- <groupId>dom4j</groupId>
- <artifactId>dom4j</artifactId>
- </exclusion>
- </exclusions>
+ <artifactId>maven-reporting-api</artifactId>
+ <version>3.1.1</version>
</dependency> But it turns out that something in this plugin depends on
Since I didn't write this code and have no experience writing Maven plugins, I have no idea what
Apparently because
Apparently not, as described above. In any case I do not see how switching the dependency from |
Let me check this later today and get back to you |
Looking into now. First of all, I would recommend to resolve this problem:
|
Here it is, incomplete because generate(3 arg) requires some polish, but it compiles: osipovmi@deblndw011x:~/var/Projekte/maven-jellydoc-plugin (master *>)
$ git diff -U0
diff --git a/maven-jellydoc-plugin/src/main/java/org/jvnet/maven/jellydoc/JellydocMojo.java b/maven-jellydoc-plugin/src/main/java/org/jvnet/maven/jellydoc/JellydocMojo.java
index 12aa447..7ccd18f 100644
--- a/maven-jellydoc-plugin/src/main/java/org/jvnet/maven/jellydoc/JellydocMojo.java
+++ b/maven-jellydoc-plugin/src/main/java/org/jvnet/maven/jellydoc/JellydocMojo.java
@@ -32 +32 @@ import org.apache.maven.project.MavenProjectHelper;
-import org.apache.maven.reporting.MavenReport;
+import org.apache.maven.reporting.MavenMultiPageReport;
@@ -41 +41,4 @@ import org.apache.tools.ant.types.Path;
-import org.codehaus.doxia.sink.Sink;
+import org.apache.maven.doxia.sink.Sink;
+import org.apache.maven.doxia.sink.SinkFactory;
+import org.apache.maven.doxia.siterenderer.RenderingContext;
+import org.apache.maven.doxia.siterenderer.sink.SiteRendererSink;
@@ -70 +73 @@ import java.util.Locale;
-public class JellydocMojo extends AbstractMojo implements MavenReport {
+public class JellydocMojo extends AbstractMojo implements MavenMultiPageReport {
@@ -208,0 +212,4 @@ public class JellydocMojo extends AbstractMojo implements MavenReport {
+ public void generate(org.codehaus.doxia.sink.Sink sink, Locale locale) throws MavenReportException {
+ generate(sink, null, locale);
+ }
+
@@ -209,0 +217,5 @@ public class JellydocMojo extends AbstractMojo implements MavenReport {
+ generate(sink, null, locale);
+ }
+
+ @Override
+ public void generate(Sink sink, SinkFactory sinkFactory, Locale locale) throws MavenReportException {
diff --git a/maven-jellydoc-plugin/src/main/java/org/jvnet/maven/jellydoc/ReferenceRenderer.java b/maven-jellydoc-plugin/src/main/java/org/jvnet/maven/jellydoc/ReferenceRenderer.java
index 6a532f4..24262fd 100644
--- a/maven-jellydoc-plugin/src/main/java/org/jvnet/maven/jellydoc/ReferenceRenderer.java
+++ b/maven-jellydoc-plugin/src/main/java/org/jvnet/maven/jellydoc/ReferenceRenderer.java
@@ -23 +23 @@ import org.dom4j.io.SAXReader;
-import org.codehaus.doxia.sink.Sink;
+import org.apache.maven.doxia.sink.Sink; |
Brilliant! Thanks Michael, the pointer to |
No description provided.