Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shade commons-lang3 and commons-text #10

Merged
merged 2 commits into from
Jul 31, 2020
Merged

Shade commons-lang3 and commons-text #10

merged 2 commits into from
Jul 31, 2020

Conversation

timja
Copy link
Member

@timja timja commented Jul 31, 2020 •
edited
Loading

Only picks up commons-lang2 now

$ mvn dependency:tree | grep commons-lang
[INFO] |  |  +- commons-lang:commons-lang:jar:2.6:compile (optional)

@timja timja added the chore label Jul 31, 2020
@timja timja mentioned this pull request Jul 31, 2020
Merged
14 tasks
timja
timja commented Jul 31, 2020
View reviewed changes
pom.xml Show resolved Hide resolved
@timja timja mentioned this pull request Jul 31, 2020
Closed
@jglick jglick changed the title Shade commons-lang3 Shade commons-lang3 and commons-text Jul 31, 2020
@jglick jglick merged commit 2c97b8f into master Jul 31, 2020
@jglick jglick deleted the shade-commons-lang3 branch July 31, 2020 14:05
@jglick
Copy link
Member

jglick commented Jul 31, 2020

I wonder if we want to define relocations for these so that there is no clash in case someone has a different version in their test classpath? Unlikely to matter, but possible.

@timja
Copy link
Member Author

timja commented Jul 31, 2020

Was wondering about that but I guess we can iterate on it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jglick jglick jglick approved these changes

@oleg-nenashev oleg-nenashev Awaiting requested review from oleg-nenashev

@uhafner uhafner Awaiting requested review from uhafner

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timja @jglick