Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: Jenkins test harness no longer compiles against recent cores #370

Closed
basil opened this issue Dec 23, 2021 · 4 comments · Fixed by #386
Closed

Regression: Jenkins test harness no longer compiles against recent cores #370

basil opened this issue Dec 23, 2021 · 4 comments · Fixed by #386
Assignees
@jglick
Labels
dependencies Pull requests that update a dependency file

Comments

@basil
Copy link
Member

basil commented Dec 23, 2021

As of jenkinsci/jenkins#5320, the Jenkins test harness no longer compiles against recent cores: ExtractChangeLogParser#parse

Should be easy enough to fix in the usual way; see jenkinsci/subversion-plugin#259 and jenkinsci/jep#367.

CC @olamy @batmat
@basil basil added the bug label Dec 23, 2021
@basil
Copy link
Member Author

basil commented Jan 14, 2022

@olamy @batmat Gentle ping.

@jglick jglick added chore dependencies Pull requests that update a dependency file and removed bug chore labels Jan 19, 2022
@olamy olamy self-assigned this Feb 6, 2022
olamy added a commit to olamy/jenkins-test-harness that referenced this issue Feb 6, 2022
@olamy
Fix jenkinsci#370 Jenkins test harness no longer compiles against rec…
23a88cd 
…ent cores

Signed-off-by: Olivier Lamy <olamy@apache.org>
@jglick
Copy link
Member

jglick commented Feb 7, 2022

Rather than olamy@23a88cd I would recommend removing use of Digester altogether, as in the links in the description.

@olamy
Copy link
Member

olamy commented Feb 8, 2022

this pattern has been used for most of the plugins during migration.
what is the added value? frankly it's adding extra work/extra lines of code to maintain, digester3 doesn't have security issues and jenkins-test-harness is a test library.
I don't want to be rude but if you prefer the other way feel free to do it.

@jglick
Copy link
Member

jglick commented Feb 8, 2022

this pattern has been used for most of the plugins during migration.

Against my advice.

what is the added value?

It is about avoiding adding something else to the dependencies of JTH.

I will see if I can find a few minutes to do it.

@jglick jglick assigned jglick and unassigned olamy Feb 8, 2022
jglick added a commit to jglick/maven-plugin that referenced this issue Feb 9, 2022
@jglick
Cleanup from jenkinsci#45: jenkinsci/jenkins#1740 long since availabl…
bd1a08c 
…e, and want to be able to test jenkinsci/jenkins-test-harness#370
@jglick jglick mentioned this issue Feb 9, 2022
Merged
olamy pushed a commit to jenkinsci/maven-plugin that referenced this issue Feb 11, 2022
@jglick @basil
Update dependencies, require Jenkins 2.321+ (#247)
9887b67 
* Update plugin parent POM and dependencies
* Remove old version of classworlds
* Cleanup from #45: jenkinsci/jenkins#1740 long since available, and want to be able to test jenkinsci/jenkins-test-harness#370

Co-authored-by: Basil Crow <me@basilcrow.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jglick jglick

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove Digester dep from ExtractChangeLogParser jglick/jenkins-test-harness
3 participants
@olamy @basil @jglick