Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-58362] Create ${TestPluginManager.rootDir}/${artifactId}.jpl, not the.jpl #146

Merged
merged 1 commit into from
Jul 10, 2019

Conversation

jglick
Copy link
Member

@jglick jglick commented Jul 5, 2019

While TestHplMojo creates target/test-classes/the.hpl, when we are actually setting up a plugin directory we should be copying this to a filename which reflects this plugin’s identifier. Useful in conjunction with jenkinsci/jenkins#4100.

@jglick jglick changed the title Create ${TestPluginManager.rootDir}/${artifactId}.jpl, not the.jpl [JENKINS-58362] Create ${TestPluginManager.rootDir}/${artifactId}.jpl, not the.jpl Jul 5, 2019
@jglick jglick requested a review from a team July 9, 2019 18:09
Copy link
Contributor

@jeffret-b jeffret-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it should work fine. I haven't tested it out but it makes more sense.

@jglick jglick merged commit f4f65dc into jenkinsci:master Jul 10, 2019
@jglick jglick deleted the the.jpl branch July 10, 2019 17:54
@jglick jglick added the bug label Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants