Fix missing logs in showAgentLogs
#149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
oleg-nenashev
approved these changes
Jul 23, 2019
jglick
added a commit
to jglick/workflow-durable-task-step-plugin
that referenced
this pull request
Jul 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to use my new utility from #127, I kept on missing remote log messages, even (randomly) in the original use case of
FileLogStorageTest. At first I suspected that jenkinsci/jenkins#3961 was to blame, and indeed aflushcall might be necessary, but I was running on an older core prior to this patch! Finally I recalled thatLoggercan be garbage-collected and your customizations lost. With this patch, I am getting messages reliably at last.