-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump hamcrest-library from 1.3 to 2.1 #161
Bump hamcrest-library from 1.3 to 2.1 #161
Conversation
Bumps [hamcrest-library](https://github.com/hamcrest/JavaHamcrest) from 1.3 to 2.1. - [Release notes](https://github.com/hamcrest/JavaHamcrest/releases) - [Changelog](https://github.com/hamcrest/JavaHamcrest/blob/master/CHANGES.md) - [Commits](hamcrest/JavaHamcrest@hamcrest-java-1.3...v2.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
While no api changes have occurred since 1.3, packaging has changed. The core and library jars are now empty, but still needed to force junit and other consumers to use the newer versions.
@jglick |
BTW you do not need to do tricks like create a fresh commit. You can just |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK I guess? Have you tried consuming this in a plugin that uses Hamcrest?
I meant, consuming this PR. Sometimes dependency resolution is weird. |
@jglick |
Good enough for me |
OK, no negative feedback here. |
This change supersedes #151.
While no api changes have occurred since 1.3, packaging has changed.
The core and library jars are now empty, but still needed to force JUnit and other consumers to use the newer versions.
Closes #151
@oleg-nenashev @jglick