Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump hamcrest-library from 1.3 to 2.1 #161

Conversation

bitwiseman
Copy link
Contributor

@bitwiseman bitwiseman commented Aug 24, 2019

This change supersedes #151.

While no api changes have occurred since 1.3, packaging has changed.
The core and library jars are now empty, but still needed to force JUnit and other consumers to use the newer versions.

Closes #151
@oleg-nenashev @jglick

dependabot-preview bot and others added 2 commits August 23, 2019 17:03
While no api changes have occurred since 1.3, packaging has changed.
The core and library jars are now empty, but still needed to force
junit and other consumers to use the newer versions.
@bitwiseman bitwiseman changed the title Dependabot/maven/org.hamcrest hamcrest library 2.1 Bump hamcrest-library from 1.3 to 2.1 Aug 24, 2019
@bitwiseman
Copy link
Contributor Author

@jglick
Thoughts?

@oleg-nenashev oleg-nenashev added the dependencies Pull requests that update a dependency file label Aug 29, 2019
@jglick
Copy link
Member

jglick commented Aug 29, 2019

Closes #151

BTW you do not need to do tricks like create a fresh commit. You can just git pull another PR into your own. If and when the bigger PR is merged, the smaller PR will be considered merged as well. DAG history works.

Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I guess? Have you tried consuming this in a plugin that uses Hamcrest?

@jglick
Copy link
Member

jglick commented Aug 30, 2019

I meant, consuming this PR. Sometimes dependency resolution is weird.

@bitwiseman
Copy link
Contributor Author

@jglick
Will this do? jenkinsci/github-branch-source-plugin#241 Or do you need me to create a separate PR to test this incremental?

@oleg-nenashev
Copy link
Member

Good enough for me

@oleg-nenashev
Copy link
Member

OK, no negative feedback here. :shipit:
Thanks @bitwiseman !

@oleg-nenashev oleg-nenashev merged commit ea28426 into jenkinsci:master Oct 8, 2019
slonopotamus added a commit to slonopotamus/jenkins that referenced this pull request Oct 18, 2019
slonopotamus added a commit to slonopotamus/jenkins that referenced this pull request Oct 18, 2019
slonopotamus added a commit to slonopotamus/jenkins that referenced this pull request Oct 18, 2019
slonopotamus added a commit to slonopotamus/jenkins that referenced this pull request Oct 24, 2019
@bitwiseman bitwiseman deleted the dependabot/maven/org.hamcrest-hamcrest-library-2.1 branch October 29, 2019 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants