Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade htmlunit to 2.36.0 #171

Merged
merged 4 commits into from
Dec 10, 2019
Merged

Conversation

timja
Copy link
Member

@timja timja commented Oct 9, 2019

pom.xml Outdated Show resolved Hide resolved
* @param domNode the node to start searching from
* @param xpathExpr the XPath expression
* @return the list of objects found.
*/
public static <E> List<E> selectNodes(final DomNode domNode, final String xpathExpr) {
WebClientUtil.waitForJSExec(domNode.getPage().getWebClient());
return (List) XPathUtils.getByXPath(domNode, xpathExpr, null);
return (List) XPathHelper.getByXPath(domNode, xpathExpr, null, true);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with that, but I would rather like to release the staged fixes first. HTMLUnit always causes regressions in downstream test suites

@Override
public void warn(String s, String s1, int i, String s2, int i1) {

}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would make sense to use the implementation in https://github.com/jenkinsci/jenkins-test-harness/pull/179/files so the change matches better with the current coding style: no (meaningless) comment, correct parameter names, no empty line.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

take whichever, they should be pretty much the same PR now

@oleg-nenashev oleg-nenashev added dependencies Pull requests that update a dependency file and removed on-hold labels Nov 22, 2019
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is ready to go. It will likely cause compatibility issues in the downstream (as always), but we are kinda used to that

@oleg-nenashev oleg-nenashev requested a review from a team November 22, 2019 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants