[JENKINS-60410] Disable stack trace suppression for tests. #201
Conversation
This matches other existing behavior. It makes testing and troubleshooting a little easier. Some tests depend upon test error messages or stack traces.
|
Hmm ... looks like maybe incrementals publishing is broken again. |
|
Let's see if incrementals is working now. |
I've merged master as it was skipped in the last build due to not being up to date |
|
Thanks for that @timja. I forgot about checking if master was up-to-date. |
There was a problem hiding this comment.
Looks OK, but Dispatcher.TRACE = true; two lines up is a lot nicer.
Hence https://github.com/jenkinsci/jenkins/pull/4389/files#r379862468
|
Putting this on-hold for some discussion on the disabling mechanism happening over in the companion core PR. Once I get that addressed, I'll update this one. |
|
Removing the on-hold label as the concerns, especially relating to the other PR in core, have been accepted. This should now be ready for a release so the core PR can proceed. |
|
jenkinsci/jenkins#4389 needs to be merged/released first |
|
@oleg-nenashev , since this just adds a property, this one isn't dependent on the change in core. It just doesn't do anything until this release is integrated with that change. This one should be good to go now. I'm double-checking whether this change in jenkins-test-harness is required for getting the tests to all pass for the PR in core. |
|
We will keep this on hold, until I verify the state with the other PR, though. |
|
This one is ready to go and the on-hold can be removed. As explained, this is not dependent on the core change. Instead, it enables the tests to pass for the core change. It would be great to get this merged and released so the core PR can move forward. |
If this property is set and if the changes in jenkinsci/jenkins#4389 are active, then this changes the default behavior to show full stack traces. (It enables stack traces.) If the property isn't set with 4389 then stack traces are suppressed and some tests that check error results fail. If the property is set without 4389 then it's a no-op.
This matches other existing behavior. See the nearby line for allowing Dispatcher tracing,
Dispatcher.TRACE.It makes testing and troubleshooting a little easier.