LoggerRule improvements #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Don't duplicate records with level INFO or above * quiet() allows to record log messages but not print them to console. Useful if there are multiple LoggerRule instances.
jglick
reviewed
Nov 13, 2020
| @@ -284,4 +297,22 @@ public void describeTo(org.hamcrest.Description description) { | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * Delegates to the given Handler but filter out records higher or equal to its initial level | |||
There was a problem hiding this comment.
Did you see #145 and specifically verify this behavior?
There was a problem hiding this comment.
I didn't see it before, but afaics all the FINE logs were ok when I verified it.
There was a problem hiding this comment.
Great, just verifying that you tested more carefully than I did in #138. 😞
Co-authored-by: Jesse Glick <jglick@cloudbees.com>
jglick
approved these changes
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INFOor abovequiet()allows to record log messages but not print them to console. Useful if there are multiple LoggerRule instances.