Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise default permissions of JUnit5JenkinsRule #910

Merged
merged 1 commit into from
Jan 27, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

import edu.umd.cs.findbugs.annotations.NonNull;
import java.lang.reflect.Method;

import hudson.security.ACL;
import org.junit.jupiter.api.extension.ExtensionContext;
import org.junit.jupiter.api.extension.ParameterContext;
import org.junit.runner.Description;
Expand All @@ -26,6 +28,9 @@ class JUnit5JenkinsRule extends JenkinsRule {

@Override
public void recipe() throws Exception {
// so that test code has all the access to the system
ACL.as2(ACL.SYSTEM2);

JenkinsRecipe jenkinsRecipe =
context.findAnnotation(JenkinsRecipe.class).orElse(null);
if (jenkinsRecipe != null) {
Expand Down
54 changes: 54 additions & 0 deletions src/test/java/org/jvnet/hudson/test/JenkinsRulePermissionTest.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
package org.jvnet.hudson.test;

import hudson.security.Permission;
import org.junit.Assert;
import org.junit.Rule;
import org.junit.jupiter.api.Assertions;
import org.jvnet.hudson.test.junit.jupiter.WithJenkins;

/**
* Validates that JUnit4 and JUnit5 based {@link JenkinsRule} implementations have the same default authorization and permissions.
*/
@SuppressWarnings("deprecation")
public class JenkinsRulePermissionTest {

@Rule
public JenkinsRule junit4rule = new JenkinsRule();

@org.junit.Test
public void junit4() {
MockAuthorizationStrategy strategy = new MockAuthorizationStrategy();
junit4rule.getInstance().setAuthorizationStrategy(strategy);

// basic permissions
Assert.assertTrue(junit4rule.getInstance().getACL().hasPermission(Permission.READ));
Assert.assertTrue(junit4rule.getInstance().getACL().hasPermission(Permission.WRITE));
Assert.assertTrue(junit4rule.getInstance().getACL().hasPermission(Permission.CREATE));
Assert.assertTrue(junit4rule.getInstance().getACL().hasPermission(Permission.UPDATE));
Assert.assertTrue(junit4rule.getInstance().getACL().hasPermission(Permission.DELETE));
Assert.assertTrue(junit4rule.getInstance().getACL().hasPermission(Permission.CONFIGURE));

// admin permissions
Assert.assertTrue(junit4rule.getInstance().getACL().hasPermission(Permission.FULL_CONTROL));
Assert.assertTrue(junit4rule.getInstance().getACL().hasPermission(Permission.HUDSON_ADMINISTER));
}

@org.junit.jupiter.api.Test
@WithJenkins
void junit5(JenkinsRule junit5rule) {
MockAuthorizationStrategy strategy = new MockAuthorizationStrategy();
junit5rule.getInstance().setAuthorizationStrategy(strategy);

// basic permissions
Assertions.assertTrue(junit5rule.getInstance().getACL().hasPermission(Permission.READ));
Assertions.assertTrue(junit5rule.getInstance().getACL().hasPermission(Permission.WRITE));
Assertions.assertTrue(junit5rule.getInstance().getACL().hasPermission(Permission.CREATE));
Assertions.assertTrue(junit5rule.getInstance().getACL().hasPermission(Permission.UPDATE));
Assertions.assertTrue(junit5rule.getInstance().getACL().hasPermission(Permission.DELETE));
Assertions.assertTrue(junit5rule.getInstance().getACL().hasPermission(Permission.CONFIGURE));

// admin permissions
Assertions.assertTrue(junit5rule.getInstance().getACL().hasPermission(Permission.FULL_CONTROL));
Assertions.assertTrue(junit5rule.getInstance().getACL().hasPermission(Permission.HUDSON_ADMINISTER));
}
}
Loading