Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split one test into two in MarkupTextTest #10226

Merged
merged 2 commits into from
Feb 8, 2025

Conversation

Rian-Ismael
Copy link
Contributor

@Rian-Ismael Rian-Ismael commented Jan 31, 2025

Improves the readability of the test. Splitting assertions into separate tests improves clarity and ensures each test verifies a single scenario or state. This enhances readability, maintainability, and debugging efficiency.

Testing done

Modified automated tests pass with local testing

Proposed changelog entries

N/A

Proposed upgrade guidelines

N/A

Submitter checklist

Preview Give feedback

Desired reviewers

N/A

Before the changes are marked as ready-for-merge:

Maintainer checklist

Preview Give feedback

Improves the readability of the test. Splitting assertions into separate tests improves clarity and ensures each test verifies a single scenario or state. This enhances readability, maintainability, and debugging efficiency.
Copy link

welcome bot commented Jan 31, 2025

Yay, your first pull request towards Jenkins core was created successfully! Thank you so much!

A contributor will provide feedback soon. Meanwhile, you can join the chats and community forums to connect with other Jenkins users, developers, and maintainers.

@MarkEWaite MarkEWaite added tests This PR adds/removes/updates test cases skip-changelog Should not be shown in the changelog labels Jan 31, 2025
@MarkEWaite MarkEWaite changed the title Update MarkupTextTest.java Split one test into two in MarkupTextTest Jan 31, 2025
Co-authored-by: Kris Stern <krisstern@outlook.com>
@Rian-Ismael Rian-Ismael requested a review from krisstern February 3, 2025 12:19
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback.

/label ready-for-merge

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Feb 7, 2025
@MarkEWaite MarkEWaite merged commit 72d2b7b into jenkinsci:master Feb 8, 2025
16 checks passed
Copy link

welcome bot commented Feb 8, 2025

Congratulations on getting your very first Jenkins core pull request merged 🎉🥳

This is a fantastic achievement, and we're thrilled to have you as part of our community! Thank you for your valuable input, and we look forward to seeing more of your contributions in the future!

We would like to invite you to join the community chats and forums to meet other Jenkins contributors 😊
Don't forget to check out the participation page to learn more about how to contribute to Jenkins.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog tests This PR adds/removes/updates test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants