Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include trailing slash in /computer/xxx/ links #10269

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

jglick
Copy link
Member

@jglick jglick commented Feb 13, 2025

Otherwise org.kohsuke.stapler.DirectoryishDispatcher has to serve a 302 to the correct URL, which is wasteful.

Testing done

Interactive testing with mock-agent used from both freestyle and Pipeline jobs in various views.

Proposed changelog entries

N/A (too minor?)

Proposed upgrade guidelines

N/A

Desired reviewers

@Vlatombe

Before the changes are marked as ready-for-merge:

Maintainer checklist

Preview Give feedback

@timja timja added the skip-changelog Should not be shown in the changelog label Feb 14, 2025
@timja timja merged commit 5d22f04 into jenkinsci:master Feb 14, 2025
15 checks passed
@jglick jglick deleted the computer-trailing-slash branch February 14, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants