Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gitpod Dockerfile to use Java JDK 21 by default #10311

Merged
merged 3 commits into from
Feb 22, 2025

Conversation

SohamJuneja
Copy link
Contributor

@SohamJuneja SohamJuneja commented Feb 21, 2025

Fixes JENKINS-75324. Updated dockerfile for gitpod so that it uses Java JDK 21 by default. Not tested currently because it required IntelliJ subscription to connect to Gitpod .

Testing done

Proposed changelog entries

  • (skip-changelog)

Proposed changelog category

/label skip-changelog

Proposed upgrade guidelines

N/A

Submitter checklist

  • The Jira issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@krisstern

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

Copy link

welcome bot commented Feb 21, 2025

Yay, your first pull request towards Jenkins core was created successfully! Thank you so much!

A contributor will provide feedback soon. Meanwhile, you can join the chats and community forums to connect with other Jenkins users, developers, and maintainers.

@comment-ops-bot comment-ops-bot bot added the rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Feb 21, 2025
@MarkEWaite MarkEWaite added developer Changes which impact plugin developers and removed rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted labels Feb 21, 2025
@krisstern
Copy link
Member

Tested on Gitpod it worked:

Screenshot 2025-02-22 at 12 19 47 AM

Copy link
Member

@krisstern krisstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krisstern krisstern changed the title Update Dockerfile to use Java21 by default Update Dockerfile to use Java JDK 21 by default Feb 21, 2025
@comment-ops-bot comment-ops-bot bot added the rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Feb 21, 2025
@krisstern krisstern changed the title Update Dockerfile to use Java JDK 21 by default Update Gitpod Dockerfile to use Java JDK 21 by default Feb 21, 2025
@krisstern krisstern removed the rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Feb 21, 2025
Copy link

@A1exKH A1exKH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@krisstern krisstern requested a review from timja February 22, 2025 05:04
@comment-ops-bot comment-ops-bot bot added the skip-changelog Should not be shown in the changelog label Feb 22, 2025
@timja
Copy link
Member

timja commented Feb 22, 2025

I've removed the changelog entry as this isn't user facing

@SohamJuneja
Copy link
Contributor Author

@timja I've applied the desired changes.

@timja timja removed the developer Changes which impact plugin developers label Feb 22, 2025
@krisstern krisstern requested a review from timja February 22, 2025 16:44
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:

Picked up JAVA_TOOL_OPTIONS: -XX:+UseContainerSupport -XX:ActiveProcessorCount=1
Apache Maven 3.9.9 (8e8579a9e76f7d015ee5ec7bfcdc97d260186937)
Maven home: /home/gitpod/.sdkman/candidates/maven/current
Java version: 21.0.6, vendor: Eclipse Adoptium, runtime: /home/gitpod/.sdkman/candidates/java/21.0.6-tem
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "6.1.91-060191-generic", arch: "amd64", family: "unix"

@timja timja merged commit fef79c4 into jenkinsci:master Feb 22, 2025
9 of 10 checks passed
Copy link

welcome bot commented Feb 22, 2025

Congratulations on getting your very first Jenkins core pull request merged 🎉🥳

This is a fantastic achievement, and we're thrilled to have you as part of our community! Thank you for your valuable input, and we look forward to seeing more of your contributions in the future!

We would like to invite you to join the community chats and forums to meet other Jenkins contributors 😊
Don't forget to check out the participation page to learn more about how to contribute to Jenkins.


@SohamJuneja
Copy link
Contributor Author

Thanks @krisstern @timja @A1exKH for reviewing this. Grateful to @krisstern for testing this !!

@SohamJuneja SohamJuneja deleted the java21 branch February 22, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants