Try to avoid test hangs

[jglick]

Observed a couple CI builds of older core branches hanging in this test for hours, I suspect because the test was failing to find the expected task but it was doing so in an endless loop that could not respond to Thread.interrupt despite the standard 3m timeout in JenkinsRule.

Possible that jenkinsci/jenkins-test-harness#67 (integrated in #2959) would have helped.

@reviewbybees

[ghost]

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

[Jimilian]

Maybe it will be better to directly call maintain method of Queue two times? If everything is correct it should move the task to buildable, no?

[jglick]

Maybe. @varmenise’s code; I am not too interested in editing it heavily, I just want it to stop causing CI outages.

[jglick]

CI failure looks random:

Connect to repo.azure.jenkins.io:443 [repo.azure.jenkins.io/13.68.19.38] failed: Connection refused

[daniel-beck]

Windows build passed, but I triggered it again anyway.

[jglick]

I am not sure what this

junit.framework.AssertionFailedError: test failure
	at junit.framework.Assert.fail(Assert.java:47)
	at org.jvnet.hudson.test.BuildTriggerTest.testSomething(BuildTriggerTest.java:7)

is about. There is no such test class or test method that I can see, in this repo or anywhere else. I do not have workspace view permission even if the workspace still exists.

[jglick]

AgentProtocolTest.testShouldNotDisableProtocolsForMigratedInstances failure, unrelated (#3012).

[oleg-nenashev]

🐝 whatever works

[jglick]

There is no such test class or test method that I can see, in this repo or anywhere else.

FTR this was src/test/java/org/jvnet/hudson/test/BuildTriggerTest.java in test/src/test/resources/hudson/tasks/maven-test-failure.zip. How it “escaped” to the project test results, I am not sure…

[jglick]

Ah, perhaps because we are archiving **/target/surefire-reports/*.xml when we should be doing only */target/surefire-reports/*.xml.