Some more refinements to ClassFilterImpl shutoff during development #3237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
oleg-nenashev
approved these changes
Jan 17, 2018
jglick
commented
Jan 18, 2018
| return true; | ||
| } | ||
| if (loc.endsWith("/target/classes/")) { | ||
| LOGGER.log(Level.FINE, "{0} seems to be current plugin classes, OK", loc); |
There was a problem hiding this comment.
Confirmed by linking …/mock-slave-plugin/target/test-classes/the.hpl to $JENKINS_HOME/plugins/mock-slave.jpl, creating a ClassFilterImpl logger, creating a mock slave, and running with plain java -jar jenkins.war:
file:…/mock-slave-plugin/target/classes/ seems to be current plugin classes, OK
permitting org.jenkinci.plugins.mock_slave.MockSlave due to its location in file:…/mock-slave-plugin/target/classes/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should not be a user-visible change.
java -jar jenkins.war(as opposed tomvn hpi:run) when supporting$JENKINS_HOME/plugins/*.jpl, as is occasionally useful.ghprb-plugin(after POM update ghprb-plugin#615) where Jenkins fails to detect that Mockito is in use and the class filter needs to be disabled.@reviewbybees