[JENKINS-46386] Make SystemProperties safe to call from agent JVMs #3362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
added
the
needs-more-reviews
6 tasks
oleg-nenashev
approved these changes
Mar 22, 2018
There was a problem hiding this comment.
LGTM. The difference in #3065 is mostly about potential extensibility of engine. Likely YAGNI
🐝
daniel-beck
approved these changes
Mar 22, 2018
|
@reviewbybees done |
oleg-nenashev
added
ready-for-merge
Exactly. Since the API remains restricted, we are free to refactor to an extension point if it seems necessary. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JENKINS-46386. Tested manually using steps given in JIRA.
Accomplishes basically the same thing as #3065, but much more simply. Filing this now because the effectiveness of #3067 seems to have been lost after #3173.
Proposed changelog entries
Desired reviewers
@jenkinsci/code-reviewers @reviewbybees