Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced LineTransformationOutputStream.Delegating #3959

Merged

Conversation

jglick
Copy link
Member

@jglick jglick commented Apr 2, 2019

Split out of #3703.

Proposed changelog entries

  • New convenience API: LineTransformationOutputStream.Delegating.
  • JENKINS-56995: Properly flushing output from the Maven console annotator.

…otator had neglected to implement flush properly.

(cherry picked from commit 4c6be45)
@jglick jglick merged commit e57d7a5 into jenkinsci:master Apr 8, 2019
@jglick jglick deleted the LineTransformationOutputStream.Delegating branch April 8, 2019 17:02
@daniel-beck
Copy link
Member

@jglick

Properly flushing output from the Maven console annotator.

Is this a standalone change (perhaps with Jira issue for the bug), or just adapting to the API addition?

@jglick
Copy link
Member Author

jglick commented Apr 12, 2019

That is a standalone change. While dealing with flush() issues generally, I had searched for LineTransformationOutputStream implementations that neglected to do this right, and found a few including this one. I suppose it could be backportable for the benefit of the pipeline-maven plugin, but the new API would not be there, so it would be a distinct patch for LTS: adding

    @Override
    public void flush() throws IOException {
        out.flush();
    }

@jglick
Copy link
Member Author

jglick commented Apr 12, 2019

Anyway I filed JENKINS-56995 for it just in case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants