Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecating Run.getLogFile #3963

Merged
merged 2 commits into from
Apr 3, 2019
Merged

Deprecating Run.getLogFile #3963

merged 2 commits into from
Apr 3, 2019

Conversation

jglick
Copy link
Member

@jglick jglick commented Apr 2, 2019

See JENKINS-38381.

Proposed changelog entries

  • Noting that Run.getLogFile() should not be used, as it is not compatible with JEP-210. Other log-related methods are implemented properly in workflow-job.

@oleg-nenashev
Copy link
Member

#3557 could resolve the compatibility issue tho

Co-Authored-By: jglick <jglick@cloudbees.com>
@jglick
Copy link
Member Author

jglick commented Apr 2, 2019

resolve the compatibility issue

getLogFile still works, even when using pipeline-cloudwatch-logs, it is just inefficient.

@jglick jglick merged commit a0f25a9 into jenkinsci:master Apr 3, 2019
@jglick jglick deleted the Run.logFile branch April 3, 2019 14:25
sghill added a commit to sghill-rewrite/description-setter-plugin that referenced this pull request Jul 30, 2023
Replace deprecated Run#getLogFile() method with preferred #getLogReader().
Method has been deprecated since jenkinsci/jenkins#3963 in April 2019.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants