Un-restrict the XMLUtils class after SECURITY-521 release #4032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- It was forgotten since that actually
jtnord
approved these changes
May 17, 2019
daniel-beck
approved these changes
May 17, 2019
MRamonLeon
approved these changes
May 17, 2019
daniel-beck
reviewed
May 17, 2019
Co-Authored-By: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
oleg-nenashev
added
the
ready-for-merge
oleg-nenashev
approved these changes
May 20, 2019
jvz
approved these changes
May 20, 2019
jglick
reviewed
May 24, 2019
| @@ -37,9 +35,9 @@ | |||
| import javax.xml.xpath.XPathFactory; | |||
|
|
|||
| /** | |||
| * Utilities useful when working with various XML types. | |||
| * Utilities useful when working with various XML types. | |||
| * @since 1.596.1 and 1.600, unrestricted since TODO | |||
There was a problem hiding this comment.
@since need only mention the version in which it was unrestricted. If anyone cares for some reason about versions in which it was present but restricted (why?), they can use Git history.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See SECURITY-521 resolved in Feb 2018.
Proposed changelog entries
Submitter checklist
* Use the
Internal:prefix if the change has no user-visible impact (API, test frameworks, etc.)Desired reviewers
@jtnord @MRamonLeon @daniel-beck