Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-57713] Revert "Merge pull request #4005 from jeffret-b/remoting/3.30 #4047

Merged
merged 1 commit into from
May 30, 2019
Merged

[JENKINS-57713] Revert "Merge pull request #4005 from jeffret-b/remoting/3.30 #4047

merged 1 commit into from
May 30, 2019

Conversation

olivergondza
Copy link
Member

As per regression discovered during LTS RC testing, I suggest to revert this change both in master and LTS until remoting is fixed.

This reverts commit 2a11ba6 / PR #4005.

See JENKINS-57713.

Proposed changelog entries

  • JNLP agents fail to connect cloud agents in certain situations. Remoting version reverted to 3.29 to avoid the regression.

Submitter checklist

  • JIRA issue is well described
  • Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    * Use the Internal: prefix if the change has no user-visible impact (API, test frameworks, etc.)
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@amuniz, @oleg-nenashev, @jeffret-b

@olivergondza
[JENKINS-57713] Revert "Merge pull request jenkinsci#4005 from jeffre…
a9c9412 
…t-b/remoting/3.30"

This reverts commit 2a11ba6, reversing
changes made to 3eec7fd.
@batmat batmat closed this May 28, 2019
@batmat batmat reopened this May 28, 2019
@olivergondza olivergondza reopened this May 29, 2019
@oleg-nenashev oleg-nenashev added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label May 29, 2019
@oleg-nenashev
Copy link
Member

I will merge it towards the next weekly unless there is negative feedback

@oleg-nenashev oleg-nenashev added the regression-fix Pull request that fixes a regression in one of the previous Jenkins releases label May 29, 2019
@olivergondza
Copy link
Member Author

Thanks Oleg, I am cherrypicking a9c9412 for the LTS in that case. IOW, please do not squashmerge this.

@oleg-nenashev oleg-nenashev merged commit 892bdf1 into jenkinsci:master May 30, 2019
@olivergondza olivergondza deleted the revert-remoting branch May 31, 2019 10:35
@jglick
Copy link
Member

jglick commented Jun 3, 2019

I would have rather suggested reverting jenkinsci/remoting#193 and then integrating remoting 3.31.

@basil basil mentioned this pull request Jun 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

@amuniz amuniz amuniz approved these changes

@jtnord jtnord jtnord approved these changes

@batmat batmat batmat approved these changes

Assignees
No one assigned
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback regression-fix Pull request that fixes a regression in one of the previous Jenkins releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@olivergondza @oleg-nenashev @jglick @batmat @jtnord @amuniz