-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-62757] Introduce fingerprint migration in External Storage API #4825
Conversation
This PR is WIP currently. |
@oleg-nenashev @afalko @mikecirioli This is the migration PR. Work is done but suggest putting it on hold till #4834 is merged. |
test/src/test/java/jenkins/fingerprints/FingerprintStorageTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small question and comment improvement suggestion
@afalko @oleg-nenashev @mikecirioli request for review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend to use local variables to make the code more reliable against concurrency issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be good to go, thanks @stellargo !
We may merge it in 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 for catching the bug @stellargo . Resetting the merge timer
We may merge it in 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process
See JENKINS-62757.
See JEP-226.
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Proposed changelog entries
section only if there are breaking changes or other changes which may require extra steps from users during the upgradeDesired reviewers
@mention
Maintainer checklist
Before the changes are marked as
ready-for-merge
:Proposed changelog entries
are correctupgrade-guide-needed
label is set and there is aProposed upgrade guidelines
section in the PR title. (example)lts-candidate
to be considered (see query).