[JENKINS-64972] Help-buttons are not working when they are at the top of draggable div

[benebsiny]

See JENKINS-64972.

The 'dd-handle' div will make all events in that div (e.g. click event of a button) not triggered, so I move the help-button out of the 'dd-handle' div.
In order to make the button still at the right of the same line, I use "flex" to realize.

See demo:

Proposed changelog entries

• Fix help-buttons in the draggable section (regression in 2.264)

Proposed upgrade guidelines

N/A

Submitter checklist

• (If applicable) Jira issue is well described
• Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change). Examples
  • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
• Appropriate autotests or explanation to why this change has no tests
• For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

• There are at least 2 approvals for the pull request and no outstanding requests for change
• Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
• Changelog entries in the PR title and/or Proposed changelog entries are correct
• Proper changelog labels are set so that the changelog can be generated automatically
• If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
• If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[MarkEWaite]

I've confirmed that I can see the problem this is describing in Jenkins 2.277.1-rc. I've also confirmed that the change resolves the problem when I cherry-pick the change onto my local copy of the stable-2.277 branch. I don't know the risks associated with the change, but have confirmed that it works as expected with Jenkins 2.277.1-rc plus this patch.

My tests were using a Linux Jenkins and a Google Chrome browser on Windows 10.

[fqueiruga]

These changes could also probably be applied to the f:repeatable widget. One good screen to test both these widgets is the Global Tool Configuration screen.

[oleg-nenashev]

I tested the fix as well. I confirm it resolves the issue.
Thanks for the patch @benebsiny !

[timja]

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

[oleg-nenashev]

Should we expedite backporting of this fix into 2.277.1 @timja @fqueiruga

[timja]

unsure, it seems quite minor and isn't released in a weekly yet. I wasn't sure if it was worth the added risk

[MarkEWaite]

unsure, it seems quite minor and isn't released in a weekly yet. I wasn't sure if it was worth the added risk

I think it is minor enough that it can wait for 2.277.2 backport or later. Give it some time in the weekly.