[JENKINS-65017] Prevent bugs in form validation from messing up the entire page #5333
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple attempt to prevent NPEs and similar problems in form validation URLs from blowing up forms.
Previously, an entire Jenkins page would be shown below the affected form field, including the Logging ID that replaced stack traces, so we lose a bit of functionality here, but it's just a lot nicer looking (and could be further iterated on, e.g. by more flexibly serving 500 responses based on request type).
Manual testing: Edit any validated form field's
checkurl
to an invalid one, and observe:Before
(Current LTS)
After
(This PR)
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Proposed changelog entries
section only if there are breaking changes or other changes which may require extra steps from users during the upgradeDesired reviewers
@mention
Maintainer checklist
Before the changes are marked as
ready-for-merge
:Proposed changelog entries
are correctupgrade-guide-needed
label is set and there is aProposed upgrade guidelines
section in the PR title. (example)lts-candidate
to be considered (see query).